Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Clarification stemming from my own issues #4503

Closed
wants to merge 2 commits into from
Closed

Clarification stemming from my own issues #4503

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84c8e3a
Clarification stemming from my own issues
gdennie Oct 18, 2013
e362ab4
Update spelling and clarified
gdennie Oct 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/content/error/compile/tplrt.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
@description

When a directive is declared with `template` (or `templateUrl`) and `replace` mode on, the template must have exactly one root element.
Otherwise the replacement operation would result in a single element being replaced with multiple elements or nodes, which is unsupported and not commonly needed in practice.
That is, the text of the template property or the referenced by the templateUrl must be contained within an html elemen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "elemen"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I tried to correct after submission but could not find a way to do so.

From: Pete Bacon Darwin [mailto:[email protected]]
Sent: October 18, 2013 3:06 PM
To: angular/angular.js
Cc: gdennie
Subject: Re: [angular.js] Clarification stemming from my own issues (#4503)

In docs/content/error/compile/tplrt.ngdoc:

@@ -4,7 +4,9 @@
@description

When a directive is declared with template (or templateUrl) and replace mode on, the template must have exactly one root element.
-Otherwise the replacement operation would result in a single element being replaced with multiple elements or nodes, which is unsupported and not commonly needed in practice.
+That is, the text of the template property or the referenced by the templateUrl must be contained within an html elemen.

typo "elemen"

—
Reply to this email directly or view it on GitHub https://github.com/angular/angular.js/pull/4503/files#r7071027 .Image removed by sender.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can edit the file again within GitHub: https://github.com/gdennie/angular.js/edit/patch-5/docs/content/error/compile/tplrt.ngdoc

Alternatively, you can simply edit on your local copy (make sure you've checked out patch-5). When you're finished,

$ git commit -a --amend

And force-push

For example, '<p>blah blah blah</p>' instead of simply 'blah blah blah'.
Otherwise the replacement operation would result in a single element (the directive) being replaced with multiple elements or nodes, which is unsupported and not commonly needed in practice.


For example a directive with definition:
Expand Down