Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

update ngBind.js documentation example #4427

Closed
wants to merge 1 commit into from
Closed

update ngBind.js documentation example #4427

wants to merge 1 commit into from

Conversation

nicolasbrugneaux
Copy link
Contributor

Improved doc for ngBind

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@nicolasbrugneaux
Copy link
Contributor Author

nicolas brugneaux

@petebacondarwin
Copy link
Contributor

@nicolasbrugneaux - Thanks for the PR, there was a typo that stopped this from actually working. Once fixed, there was then the problem that $sce was kicking in and complaining that this had unsafe HTML and so was throwing a security exception rather than displaying the HTML.

You can test this stuff yourself by running:

grunt package webserver

Then browsing to http://localhost:8000/build/docs

You can also check the e2e tests by running

grunt test

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants