-
Notifications
You must be signed in to change notification settings - Fork 27.4k
add ngPoster directive for VIDEO tag. #4408
Conversation
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
New directive for proper poster video attr (works like ng-src). Added doc & spec.
LGTM - @mfo can you make sure you sign the CLA. Adding documentation and unit tests was very helpful. Be aware that it would be even better if the commit message followed the rules. |
I approved the CLA (Martin Fourcade) & updated the commit message (sorry, I missed this part). I hope it's ok now. Best |
This directive is much appreciated! I just ran into problem with |
You can also just use |
I was not aware of this directive (I just searched for it in the reference api but it's missing). I'll read the code of boolean attr later, but :
Let me know if you wish a better pull request. |
Thnaks a lot for the |
I believe |
I did not know about |
@buunguyen – that wouldn't make sense. I'm going to close this. |
A teeny tiny commit adding support for poster's video attribute (http://dev.w3.org/html5/spec-author-view/video.html#attr-video-poster).
<video ng-poster="{{super-poster-url}}"></video>
Thanks for this awesome front end framework :-)