Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(orderBy): speed optimization #4282

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions src/ng/filter/orderBy.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,17 +101,34 @@ function orderByFilter($parse){
}
get = $parse(predicate);
}
return reverseComparator(function(a,b){
return compare(get(a),get(b));
}, descending);
return {
getter: get,
comparator: reverseComparator(function(a, b) {
return compare(a, b);
}, descending)
};
});

// Schwartzian transform
var sorted = map(array, function(item) {
return {
item: item,
predicate: map(sortPredicate, function(obj) {
return obj.getter(item);
})
};
}).sort(reverseComparator(comparator, reverseOrder));

return map(sorted, function(obj) {
return obj.item;
});
var arrayCopy = [];
for ( var i = 0; i < array.length; i++) { arrayCopy.push(array[i]); }
return arrayCopy.sort(reverseComparator(comparator, reverseOrder));

function comparator(o1, o2){
for ( var i = 0; i < sortPredicate.length; i++) {
var comp = sortPredicate[i](o1, o2);
var comp = sortPredicate[i].comparator(
o1.predicate[i],
o2.predicate[i]
);
if (comp !== 0) return comp;
}
return 0;
Expand Down