Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

(1) Clarified directive e2e test result and (2) template referencing exa... #4237

Closed
wants to merge 1 commit into from

Conversation

gdennie
Copy link
Contributor

@gdennie gdennie commented Oct 2, 2013

...mples

In the first case, the use of 'angular' as sample text is confusing to the newbie (of which I am) in that they are force to confirm that the text 'angular' is not a keyword or otherwise referring to a system component. It is useful to ensure that sample text are obviously sample text.

In the second case, the introduction to the list of ways of referring to directives from the template was in obvious need to repair. I have also moved the most common example to the top of the list in companionship with the use close by of ng-model.

…examples

In the first case, the use of 'angular' as sample text is confusing to the newbie (of which I am) in that they are force to confirm that the text 'angular' is not a keyword or otherwise referring to a system component. It is useful to ensure that sample text are obviously sample text.

In the second case, the introduction to the list of ways of referring to directives from the template was in obvious need to repair. I have also moved the most common example to the top of the list in companionship with the use close by of ng-model.
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@gdennie
Copy link
Contributor Author

gdennie commented Oct 2, 2013

Signed...
George Dennie

petebacondarwin pushed a commit that referenced this pull request Oct 3, 2013
The use of 'angular' as sample text is confusing to the newbie in that they are forced
to confirm that the text 'angular' is not a keyword or otherwise referring to a system
component. This is changed to a more obvious sample text.

The most common form of `ngBind` is moved to the top of the list.

Closes #4237
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The use of 'angular' as sample text is confusing to the newbie in that they are forced
to confirm that the text 'angular' is not a keyword or otherwise referring to a system
component. This is changed to a more obvious sample text.

The most common form of `ngBind` is moved to the top of the list.

Closes angular#4237
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The use of 'angular' as sample text is confusing to the newbie in that they are forced
to confirm that the text 'angular' is not a keyword or otherwise referring to a system
component. This is changed to a more obvious sample text.

The most common form of `ngBind` is moved to the top of the list.

Closes angular#4237
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants