Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($timeout): add a $timeout example (gxlcl's example) #4180

Closed
wants to merge 1 commit into from
Closed

docs($timeout): add a $timeout example (gxlcl's example) #4180

wants to merge 1 commit into from

Conversation

Urigo
Copy link
Contributor

@Urigo Urigo commented Sep 27, 2013

No description provided.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@Urigo
Copy link
Contributor Author

Urigo commented Sep 27, 2013

I've signed the CLA - Uri Goldshtein

@petebacondarwin
Copy link
Contributor

@Urigo - thanks for the PR.

Current, the stop fight button doesn't have any effect when run in the documentation page. It works fine in Plunker.

It turns out that this a bug in bootstrap-prettify.js - https://github.com/angular/angular.js/blob/master/docs/components/angular-bootstrap/bootstrap-prettify.js#L218.
This is decorating $timeout and invalidly returning a number rather than a promise from $timeout().

So fine to merge but we need to raise an issue about the above.

petebacondarwin pushed a commit that referenced this pull request Sep 28, 2013
The original example is by gxlcl.

Closes #4180
@Urigo
Copy link
Contributor Author

Urigo commented Sep 28, 2013

Sure, so should i open an issue in angular-bootstrap?

@Urigo Urigo deleted the patch-1 branch September 28, 2013 23:18
@petebacondarwin
Copy link
Contributor

It is actually a bug in angular docs.
On 29 Sep 2013 00:18, "Uri Goldshtein" [email protected] wrote:

Sure, so should i open an issue in angular-bootstrap?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4180#issuecomment-25310763
.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The original example is by gxlcl.

Closes angular#4180
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The original example is by gxlcl.

Closes angular#4180
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants