Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(parse): changed the functionCall method to parse filters #4175

Closed
wants to merge 1 commit into from

Conversation

esarbanis
Copy link
Contributor

Added a condition to allow the parser to understand whether the parameter is actually a filter

Closes #4168

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@esarbanis
Copy link
Contributor Author

I have signed the CLA under the name of Efthymios Sarmpanis

Added a condition to allow the parser to understand whether the parameter is a filter

Closes angular#4168
@btford btford removed the gh: PR label Aug 20, 2014
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:08
@jeffbcross jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37
@lgalfaso lgalfaso self-assigned this Dec 28, 2014
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Jun 6, 2016
petebacondarwin added a commit that referenced this pull request Jun 6, 2016
Thanks to @esarbanis for the original PR that got out-dated due to the
big $parse overhaul.

Closes #4175
Closes #4168
Closes #14720
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-click and filter don't work together
5 participants