msie: documentMode detection to replace userAgent sniffing #4155
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I signed the CLA in the past... well, I just signed it one more time, with my github email, I guess it should work |
| @@ -1,5 +1,5 @@ | |||
| // Copy/pasted from src/Angular.js, so that we can disable specific tests on IE. | |||
| var msie = parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1], 10); | |||
| var msie = document.documentMode; | |||
There was a problem hiding this comment.
This breaks people using using IE7, as few of them as there are. I'm not sure if I really have a problem with this, but it's something to think about.
You know what, I'm not sure I care, this is great. Right on!
|
lgtm but let's get this in for 1.3 |
|
can you please sign the CLA |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
|
no CLA signature. we can't merge this. closing. |
|
I reimplemented this as #9398 |
To close issue #4113 and replace PR #4115, #4116, #4117, #4118, #4119