fix(ngInput): When 'name' attribute is a property name, '$name' should be evaluated to the property value

[blai]

Not exactly sure if this is a bug fix or a feature enhancement. For simple cases such as the following, it works:

<form name="myForm">
    User name: <input type="text" name="userName" ng-model="user.name" required>
    <span class="error" ng-show="myForm.userName.$error.required">Required!</span>
</form>

But if the <input> is dynamically generated and the name is a scope property, it run into issue:

<form name="myForm">
    <div ng-repeat="field in formFields">
        <span>{{field.label}}</span>
        <input type="text" name="{{field.name}}" required>
        <span class="error" ng-show="myForm[field.name].$error.required">Required!</span>
    </div>
</form>

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[blai]

Forgot if I have submitted CLA before, just did a click through once more with my name Brian Lai.

[mhevery]

this should be done through $attrs.$observe and it needs to update the forms each time attribute changes.

[petebacondarwin]

Duplicate of #3135?

[Narretz]

Implemented differently in 729c238