This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngInclude): fix regression when ngInclude is present on an element with interpolated attributes #4073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@btford you are the coolest person ever. |
|
@mary-poppins And so are you, Miss Poppins! |
| it('should work when placed on an anchor link', inject(function($compile, $rootScope, $httpBackend) { | ||
| // regression | ||
|
|
||
| element = $compile('<div><a ng-href="#/{{href}}" ng:include="\'url\'"></a></div>')($rootScope); |
There was a problem hiding this comment.
please use ng-include instead of ng:include in new tests.
|
@IgorMinar I addressed your comments. |
| @@ -281,6 +281,22 @@ describe('ngInclude', function() { | |||
| })); | |||
|
|
|||
|
|
|||
| it('should work when placed on an anchor link', inject(function($compile, $rootScope, $httpBackend) { | |||
| // regression #4073 | |||
There was a problem hiding this comment.
that's a PR# not an Issue#
…t with interpolated attributes Closes angular#3793
|
Done |
|
landed as 5eb1fb6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the right priority should be.
100was too low,1000would have put this as the same priority asngRepeat,500made the tests happy.I also added a regression test.
Closes #3793