Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(guide) broken title overflow in navlist #3822

Merged
merged 1 commit into from
Aug 31, 2013
Merged

fix(guide) broken title overflow in navlist #3822

merged 1 commit into from
Aug 31, 2013

Conversation

PatrickJS
Copy link
Contributor

Before

screen shot 2013-08-30 at 1 25 41 pm

After

screen shot 2013-08-30 at 1 25 31 pm

@btford
Copy link
Contributor

btford commented Aug 30, 2013

Confirmed that this is an issue on Chrome 29.

@matsko @jankuca does this look like the best way to fix the CSS?

@jankuca
Copy link
Contributor

jankuca commented Aug 30, 2013

LGTM. I would add padding-top/bottom: 2px too.

@PatrickJS
Copy link
Contributor Author

I added 2px padding top and bottom. @btford you should do more jsbattles

@jankuca
Copy link
Contributor

jankuca commented Aug 30, 2013

Can you squash the commits and use ems as the units for line-height?

@matsko
Copy link
Contributor

matsko commented Aug 31, 2013

lgtm. Just use em values like Jan said.

@PatrickJS
Copy link
Contributor Author

Alright, I squash the commits and used em units for line-height

jankuca added a commit that referenced this pull request Aug 31, 2013
@jankuca
Merge pull request #3822 from gdi2290/navlist-fix
44ad61e 
fix(guide): multiline items in navlist
@jankuca jankuca merged commit 44ad61e into angular:master Aug 31, 2013
@PatrickJS PatrickJS deleted the navlist-fix branch August 31, 2013 01:00
@matsko
Copy link
Contributor

matsko commented Aug 31, 2013

@jankuca you can't merge it directly, you need to merge as a push from your local branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatrickJS @btford @jankuca @matsko