This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix for issue 3616 "View source" link on docs is broken #3675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated sourceLinkSpec.js to use gruntUtil.getVersion().cdnVersion instead of the undefined gruntUtil.getVersion().number. #3616
…on().cdnVersion Update "View source" api documentation link to use gruntUtil.getVersion().cdnVersion, since gruntUtil.getVersion().number is undefined #3616
In reaction to Issue 3616, I've added a check that the version code embedded in the View Source link is in fact a defined value. Previously, it referenced gruntUtil.getVersion().number which was an undefined value.
Replaced cdnVersion with just cdn in View Source link
|
|
||
| it("should have a defined gruntUtil.getVersion().cdn property", function () { | ||
| expect(gruntUtil.getVersion().cdn).toBeDefined(); | ||
| }); |
There was a problem hiding this comment.
this test doesn't belong into this file. I would just remove it from here as we currently don't have a good way to test grunt/utils.js
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Aug 21, 2013
|
I fixed your test by using a spy. See the commit referencing this PR. |
|
Thanks, spyOn is a good approach here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves Issue #3616
"View source" link on docs is broken because it references undefined property gruntUtil.getVersion().number.
I've changed two references to instead use gruntUtil.getVersion().cdnVersion, which presently contains an appropriate string (a git tag) for linking to documentation.
(If this is not an acceptable version property to reference, perhaps there is a better one? Or, as a temporary fix perhaps we should just link to the "master" code source instead of the grunt version tagged source file.)