-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(sce) IE 7 standards mode not supported #3646
Conversation
Changed to 7 to support IE 8 in IE 7 standards mode while still protecting against quirks mode. documentMode returns the following values: 5 - quirks mode, 7 - IE 7 standards mode, 8 - IE 8 standards mode.
'documentMode' is being used to test for quirks mode. This property was introduced in IE 8 and returns one of the following values: 5 - quirks mode, 7 - IE 7 standards mode, 8 - IE 8 standards mode. Test should return 5 not 7 for quirks mode.
Added tests for IE8 in IE7 standards mode.
cc: @chirayuk - just fyi |
I just saw this now. IE8 supports CSS expressions in both quirks and IE7 compatibility mode. It's only in IE8 standards mode that IE8 disallows CSS expressions. If IE7 must be supported, it should probably be via an explicit configuration setting than by default as done in this commit. |
I think one could argue that a user is supplying an explicit configuration with IE8 in IE7 standards mode as supply nothing results in quirks mode (5) where as 7 is only returned when the app supplies the following meta tag |
This reverts commit 637c9b1. (ref angular#3633 and angular#3646) The minimum bar for $sce is IE8 in standards mode. IE7 standards mode is not supported. If you must support IE7, you should disable $sce completely. angular.module('ie7support', []).config(function($sceProvider) { // Completely disable SCE to support IE7. $sceProvider.enabled(false); });
This reverts commit 637c9b1. (ref #3633 and #3646) The minimum bar for $sce is IE8 in standards mode. IE7 standards mode is not supported. If you must support IE7, you should disable $sce completely. angular.module('ie7support', []).config(function($sceProvider) { // Completely disable SCE to support IE7. $sceProvider.enabled(false); });
I wanted IE8 standards mode at the minimum for To disable
|
Changed documentMode test from 8 to 7 to support IE 8 in IE 7 standards mode while still protecting against quirks mode. documentMode returns the following values: 5 - quirks mode, 7 - IE 7 standards mode, 8 - IE 8 standards mode. Closes #3633.