Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(gruntfile): ensure all dependent grunt tasks are called for each testing task #3421

Closed
wants to merge 2 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Aug 1, 2013

No description provided.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@matsko
Copy link
Contributor Author

matsko commented Aug 1, 2013

@btford please review! :)

@btford
Copy link
Contributor

btford commented Aug 1, 2013

Looks good, but I think you need to update the grunt-parallel task as well.

@btford
Copy link
Contributor

btford commented Aug 1, 2013

The Travis failure is legit, not due to flakiness.

@mhevery
Copy link
Contributor

mhevery commented Aug 3, 2013

@matsko Please addresse brian's comment and rebase to master

@matsko
Copy link
Contributor Author

matsko commented Aug 4, 2013

@btford updated! Please test again...

@matsko
Copy link
Contributor Author

matsko commented Aug 6, 2013

@btford can you try it again and see if causes the errors?

@btford
Copy link
Contributor

btford commented Aug 7, 2013

Your changes are good, but I'll handle merging them in when we pin down the fix for Travis flakiness (hopefully today!).

@ghost ghost assigned btford Aug 7, 2013
@matsko matsko closed this in 05b41ee Aug 9, 2013
matsko added a commit that referenced this pull request Aug 9, 2013
@IgorMinar
Copy link
Contributor

LGTM

travis issue might take long to resolve. I'm merging this in.

@matsko matsko deleted the fix_docs_grunt_package branch August 9, 2013 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants