NgModelController demo fix for html injection into contenteditable directive #3156
Conversation
…rective The 'contenteditable' div and the textarea should be passing their text values between each other not their escaped inner html. This breaks the demo as the 'required' class is not applied when the 'contenteditable' div is cleared.
|
@mjt01 - This is not really correct. The problem you are describing is caused because if you clear the How about we strip this |
The example directive, using contenteditable was not showing required even if you cleared the content from it. Closes #3156
|
Thanks Pete. Sorry to be honest a colleague pointed me at this and the way it was explained it sounded like the use of html injection was a problem rather than the actual requirement. Yes I agree with your patch to strip the br tag when the returned html is blank. Thanks for your fast review. |
The example directive, using contenteditable was not showing required even if you cleared the content from it. Closes angular#3156
The 'contenteditable' div and the textarea should be passing their text values between each other not their escaped inner html. This breaks the demo as the 'required' class is not applied when the 'contenteditable' div is cleared.