Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Issue #2343 Fix #2935

Closed
wants to merge 1 commit into from
Closed

Issue #2343 Fix #2935

wants to merge 1 commit into from

Conversation

jpalumbo
Copy link

Added $logProvider.debugEnabled method to $logProvider Mock.
Added $log.debug method to Mock.

Added $logProvider.debugEnabled method to $logProvider Mock.
Added $log.debug method to Mock.
@petebacondarwin
Copy link
Contributor

PR Checklist (Minor Bugfix)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
  • PR doesn't introduce new api
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update (if suitable)
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@petebacondarwin
Copy link
Contributor

@jpalumbo - thanks for this PR. Have you signed the CLA? We need this before we can merge your submission.
We also need unit tests similar to those for $log: a488ab1

@petebacondarwin
Copy link
Contributor

When you do add the unit tests can you rebase against a recent master and provide a single commit that has a commit message that follows our guidelines. See https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
Thanks

@chirayuk
Copy link
Contributor

Ping …

Could you please sign the CLA. We're blocked on this.

@mhevery
Copy link
Contributor

mhevery commented Jul 31, 2013

Closing due to no activity from the creator and no CLA. If CLA is signed and tests added please reopen.

@mhevery mhevery closed this Jul 31, 2013
@jpalumbo
Copy link
Author

I signed the CLA under Jonathan Palumbo a while back. Also the unit tests should be present...

@jpalumbo
Copy link
Author

It looks like the test were in another commit #2934. My apologies I am relatively new to github... How can I go about moving this changes over to this pull request?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants