This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(header): replace logo.png with logo.svg #2874
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
325908d
docs(guide/unit-testing): add expression example
siddii 508d845
test(matchers): update toThrow matcher
vojtajina 6467250
feat(ngError): add error message compression and better error messages
IgorMinar f247217
feat($compile): support multi-element directive
mhevery 513e79a
feat(ngdocs): provide support for inline variable hinting
matsko f004b87
docs(): Rectify animator.animate documentation
afc325c
fix($animator): ensure $animator calculates the highest duration + de…
matsko 44946f9
fix(jqLite): Added optional name arg in removeData
jeffbcross cd3410a
chore(docs): add reference to the blog
lgalfaso c72bec5
fix(ngController): fix indentation bug which causes example to mess up
matsko 738bf56
docs(overview.ngdoc): clarify wording
adamshaylor 18ca265
docs(guide): format snippets of code in plain text
thewarpaint 23c4df6
docs(input): provide explanation of how ngModel will affect the local…
mrlucmorin d3fd671
docs(validate-commit-msg): fix incorrect comment
JensRantil 95bd140
docs(guide/di): fix some small grammatical issues
a8f8b03
docs(guide/compiler): fix some minor language errors
manuelkiessling c05e06c
docs(guide/understanding_model): improve example consistency
7816321
docs(guide/concepts): add comment as a type of directive
eghandhari ae3104c
docs(ngClass): clarify the use of object map
mrlucmorin 7fa4ffd
docs(index): make menu links relative
siddii 560e28f
docs(sanitize): add @description section
bcee59d
docs(angular-mocks): fix typo in example
41ebf0a
docs(header): replace logo.png with logo.svg
appsforartists File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make these src URLs relative so that they work when used locally or on CI server. See http://ci.angularjs.org/job/angular.js-pete/181/artifact/build/docs/api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to. I'm only using absolute paths because they were like that when I got there. =) Relative is much nicer.
Your link is 404ing, but this one is still using the PNG. Is that link being written by a build script?
Also, how would you like that path to be written? I imagine it should be something like "/img/path.svg", but then you'd have a hole in your Jenkins build, since docs isn't mounted on /. Is there a variable I could use, like {{ IMG_PATH }}?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yours 404s as well :-) This is because Angular is rewriting the URL and the CI server is not setup to redirect deep URLs!
Try this, which is probably the same at the moment as yours anyway: http://ci.angularjs.org/job/angular.js-pete/181/artifact/build/docs/index.html
These pages are generated on every build. The CI server watches my github repos and builds and tests on changes.
You can do this locally with
grunt docs
or something.The relative path can actually just be
img/path.svg
, without the/
at the start. This works for the links in the navigation menu.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the source in /docs and didn't see any part that would dynamically rewrite the relative URL. I also tried grunt docs, and it was still relative after the build.
I cringed when I first saw the hardcoded link too, but I think I understand now why it's done. The images on angularjs.org probably don't change much, so even if you are technically pulling in a production image, everything still looks OK on staging. On the other hand, since the header is in index.html (and not one of the ngdoc pages), it doesn't get built, so there's no opportunity in the current setup to rewrite that link.
Moreover, since the fallback is done in JS, we'd need a token (like
{{ IMAGES_PATH }}
) to be able to make sure the base URL was put in the correct place in both thesrc
andonerror
attributes. Another option would be to use a<base/>
tag in index.html.Please let me know if I am mistaken, but I think what's best for now is to follow the existing convention and use the hard-coded link, unless there's an opportunity to let the build script handle it that I don't know about.