Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngMobile): touch event handling fix for when jQuery is present. #2773

Closed
wants to merge 1 commit into from

Conversation

NathanWalker
Copy link

originalEvent was not being handled properly.

@NathanWalker
Copy link
Author

It should be noted in the docs (maybe I can include the docs modification in this pull request if approved) that when using ngMobile module for the purpose of removing the 300ms click delay on mobile devices, that a necessary css style needs to be globally handled as well to complete the story:

It's great that using the ngMobile module removes the 300ms delay on mobile devices, however the device will still show the tap highlight 300ms after you tap which feels buggy. To fix, put this in your stylesheet:

* {
  -webkit-tap-highlight-color: rgba(0,0,0,0);
}

@kevin-smets
Copy link

Can't wait till this gets resolved. Got this issue in a big project at the moment (reverted to fastclick for now)

@IgorMinar
Copy link
Contributor

@shepheb can you please take a look?

@NathanWalker thanks for the fix. Can you please create a test cases for these changes? the css fix sounds very reasonable, can you please provide a separate pull request for that?

@NathanWalker
Copy link
Author

I hope to get a separate pull request regarding css fix this weekend. The next 2 weeks are going to be slammed for me, but the first week of August I will have some time to develop test cases for this. If anyone in the community has time over next 2 weeks to assist me with the unit tests, please email me or post here.

@petebacondarwin
Copy link
Contributor

PR Checklist (Minor Bugfix)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
  • PR doesn't introduce new api
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update (if suitable)
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@petebacondarwin
Copy link
Contributor

Actually, I am going to close this PR in favour of #3198 as it seems to do a little more and has unit tests. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants