Delay $anchorScroll() to handle autoscroll for nested ng-includes.
#2639
Conversation
This resolves an issue where the contents of an `ng-include` also contain an ng-include with autoscroll, like this `<div ng-repeat=".." ng-include=".." autoscroll="">`. In issue angular#2637 the element to scroll to by using `#some-anchor-name` in the url, e.g. `<a name="some-anchor-name"></a>`, is not present in the dom by the time `$anchorScroll()` is called from the ngIncludeDirective.
PR Checklist (Minor Bugfix)
|
|
Wow, I'll se what I can do. |
|
@torgeir - Any update on this? |
|
No, I haven't got around for this. Any pointers to what's not passing as far as the testing goes? E.g. for the cross-browser compatibility |
|
please have a look at these tests and use the template from your commit message to reproduce the error: https://github.com/torgeir/angular.js/blob/4fa878b580fd9799d80931a8ccc14856ec640bc4/test/ng/directive/ngIncludeSpec.js#L235-L298 |
|
@torgeir - have you signed the CLA? |
|
Unless there is further activity on this, will close next week. |
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Alright, signed. |
|
Hello, the demo is not working for me. |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
|
no tests. no merge. sorry |
This resolves an issue where the contents of an
ng-includealso contain an ng-include with autoscroll, like this<div ng-repeat=".." ng-include=".." autoscroll="">.In issue #2637 the element to scroll to by using
#some-anchor-namein the url, e.g.<a name="some-anchor-name"></a>, is not present in the dom by the time$anchorScroll()is called from the ngIncludeDirective.