fix(compile): Collecting directives from tags that will be replaced #2617
Conversation
Fix the collecting of directives from elements that will get replaced by another directive on an attribute. If the element has an attribute or class directive that will replace the entire element, then do not collect the directive on the element Closes angular#2573 BREAKING CHANGE: * Will break directives that made the assumption that any directive on the replaced element would get collected * Will break directives that expect to be collected twice when they were replaced by another directive that is marked as replace
|
|
I like this idea but it needs to be looked at very carefully. |
|
This solves only case where an element directive is duplicated via replacement merge. You could end up in the same situation just just by using different syntaxes to trigger the same directive: A better fix would be to ensure that once we collect all directives, we run though the list and ensure that each directive in the list is unique, if not we should drop all but the first occurrence of the directive. |
|
Collecting all directives and then deciding would be ideal, but we would need a lot more care as we might not have the directive template as this directive is using a |
|
Compilation is moving in a different direction, closing |
Fix the collecting of element directives from tags that will get replaced
by another directive on an attribute. If the element has an attribute
or class directive that will replace the entire element, then do not
collect the element directive on the tag
Closes #2573
BREAKING CHANGE:
on the replaced tag would get collected
were replaced by another directive