Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

FIx ng-class initialization problem #2018

Closed
wants to merge 2 commits into from
Closed

FIx ng-class initialization problem #2018

wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Contributor

Fixes issue #2009

@petebacondarwin
test(ngClass): should initialize correctly when $observe and $watch h…
162893f 
…ave different initial values

This bug caused problems where ngClass was being used to identify whether a validation directive (such as required) was invalid,
where the ng-model was being initialized to a valid value before the first digest completed.
See this fiddle: http://jsfiddle.net/RobCannon/2AJCB/
@petebacondarwin
fix(ngClass): should initialize correctly when $observe and $watch ha…
845c592 
…ve different initial values

This bug caused problems where ngClass was being used to identify whether a validation directive (such as required) was invalid,
where the ng-model was being initialized to a valid value before the first digest completed.
See this fiddle: http://jsfiddle.net/RobCannon/2AJCB/
@petebacondarwin
Copy link
Contributor Author

CI Bot likes this: http://ci.angularjs.org/job/angular.js-pete/61/

@petebacondarwin petebacondarwin mentioned this pull request Feb 16, 2013
Closed
@petebacondarwin
Copy link
Contributor Author

Better test in #2020.

@petebacondarwin petebacondarwin deleted the ngClassInit branch February 16, 2013 09:09
@petebacondarwin petebacondarwin restored the ngClassInit branch February 16, 2013 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petebacondarwin