This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($compile): '=' binding can now be optional #1889
Closed
+113
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you bind using '=' to a non-existant parent property, the compiler will throw a NON_ASSIGNABLE_MODEL_EXPRESSION exception, which is right because the model doesn't exist. This enhancement allow to specify that a binding is optional so it won't complain if the parent property is not defined. In order to mantain backward compability, the new behaviour must be specified using '=?' instead of '='. The local property will be undefined is these cases. Closes angular#909 Closes angular#1435
|
By the way, I already signed the CLA |
PR Checklist (Minor Feature)
|
|
landed as ac899d0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you bind using
'='to a non-existant parent property, the compiler will throw aNON_ASSIGNABLE_MODEL_EXPRESSIONexception, which is right because the model doesn't exist.This enhancement allow to specify that a binding is optional so it won't complain if the parent property is not defined. In order to keep backward compability, the new behaviour must be specified using
'=?'instead of'='. The local property will be undefined is these cases.Closes #909
Closes #1435