Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(i18n): add samoan locale #16837

Closed
wants to merge 1 commit into from

Conversation

DrewShirts
Copy link

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore: This PR adds the Samoan locale file for ngLocale.

What is the current behavior? (You can also link to an open issue here)
There currently is not a locale file for Samoan in ngLocale.
#7246

What is the new behavior (if this is a feature change)?
This adds the ability to translate content to Samoan.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@DrewShirts
Copy link
Author

I signed the cla.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Narretz
Copy link
Contributor

Narretz commented Feb 23, 2019

Thanks for the PR. However since we are in Long Term Stability mode we are not going to add new locales to AngularJS.

@Narretz Narretz closed this Feb 23, 2019
@DrewShirts
Copy link
Author

Thanks for the PR. However since we are in Long Term Stability mode we are not going to add new locales to AngularJS.

@Narretz, I can understand that. How long will this have to wait until we can add the Samoan locale to angular.js? Can this be scheduled for when it will be an approvable PR?

@Narretz
Copy link
Contributor

Narretz commented Feb 23, 2019

Sorry if I wasn't clear, but feature development for AngularJS is completely over. We advise everyone to use the new Angular: https://angular.io/
However, with i18n you can simply take the Samoan ngLocale module you created and add it to your application without it being in an official release.

@DrewShirts
Copy link
Author

Sorry if I wasn't clear, but feature development for AngularJS is completely over. We advise everyone to use the new Angular: https://angular.io/
However, with i18n you can simply take the Samoan ngLocale module you created and add it to your application without it being in an official release.

Sounds good. Will do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants