-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed the cla. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Thanks for the PR. However since we are in Long Term Stability mode we are not going to add new locales to AngularJS. |
@Narretz, I can understand that. How long will this have to wait until we can add the Samoan locale to angular.js? Can this be scheduled for when it will be an approvable PR? |
Sorry if I wasn't clear, but feature development for AngularJS is completely over. We advise everyone to use the new Angular: https://angular.io/ |
Sounds good. Will do. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore: This PR adds the Samoan locale file for ngLocale.
What is the current behavior? (You can also link to an open issue here)
There currently is not a locale file for Samoan in ngLocale.
#7246
What is the new behavior (if this is a feature change)?
This adds the ability to translate content to Samoan.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
No tests are available: See angular.js issue 7246: No unit tests for ngLocale #7246
This was copied and then adapted from angular/bower-angular-i18n (originally committed by @spiffy2man: Added file for Samoan language translations. bower-angular-i18n#26).