Document port number escaping in URL for $resource #1672
Conversation
| @@ -19,11 +19,13 @@ | |||
| * the need to interact with the low level {@link ng.$http $http} service. | |||
| * | |||
| * @param {string} url A parameterized URL template with parameters prefixed by `:` as in | |||
| * `/user/:username`. | |||
| * `/user/:username`. If you are using URL with a port number (e.g. `http://example.com:8080/api`), | |||
| * you'll need to escape colon character before the port number, like this: | |||
There was a problem hiding this comment.
Slight nitpicks: "a URL" instead of "URL" and "the colon" instead of "colon"
Rest looks good, thanks for opening this PR!
|
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): For corporations (print, sign and scan+email, fax or mail): |
|
I just did the CLA. |
|
@jsyrjala perfect, going to merge this one later today. |
|
Squashed 2 commits into one, changed the commit message and landed it as c398d7d. Thank you! |
|
this is good, thanks! it's obvious if you think about it |
Related to issues #1664, #1243 and #942. Also fixed one typo.