This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore(*): update minimum Yarn version, do some Yarn-related cleanups #16714
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6d6ce35
chore(*): update minimum Yarn version from 1.3.2 to 1.10.1
mgol 9c0eb6c
chore(*): change the package.json's engines grunt field to grunt-cli
mgol ba64a8b
chore(*): stop separating Yarn script arguments from script names via…
mgol 2ff3f5e
chore(*): don't install grunt-cli globally during the build
mgol cada61e
chore(*): use `yarn grunt` instead of `yarn run grunt`
mgol 9af600c
chore(*): don't define the `grunt` Yarn script
mgol 072ca42
chore(*): allow Node versions newer than 8; bump the minimum
mgol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,6 @@ | |
|
||
set -e | ||
|
||
yarn global add [email protected] | ||
|
||
mkdir -p "$LOGS_DIR" | ||
|
||
if [ "$JOB" != "ci-checks" ]; then | ||
|
@@ -13,13 +11,13 @@ fi | |
|
||
# ci-checks and unit tests do not run against the packaged code | ||
if [[ "$JOB" != "ci-checks" ]] && [[ "$JOB" != unit-* ]]; then | ||
grunt package | ||
yarn grunt package | ||
fi | ||
|
||
# unit runs the docs tests too which need a built version of the code | ||
if [[ "$JOB" = unit-* ]]; then | ||
grunt validate-angular-files | ||
grunt build | ||
yarn grunt validate-angular-files | ||
yarn grunt build | ||
fi | ||
|
||
# check this after the package, because at this point the browser_provider | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That reminds me I can shorten it to
yarn grunt
instead ofyarn run grunt
... We already use the former form in a few places.