This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Update LTS information in README and landing page #16688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
suggested changes
Sep 10, 2018
README.md
Outdated
| @@ -14,9 +14,9 @@ piece of cake. Best of all? It makes development fun! | |||
|
|
|||
| -------------------- | |||
|
|
|||
| ##### AngularJS will be moving to Long Term Support (LTS) mode on July 1st 2018: [Find out more](https://docs.angularjs.org/misc/version-support-status) | |||
| **On July 1, 2018 AngularJS entered a 3 year Long Term Support period: [Find out more]**(https://docs.angularjs.org/misc/version-support-status) | |||
There was a problem hiding this comment.
The closing ** must be either before the markdown link (i.e. before the opening [) or after the markdown link (i.e. after the closing )).
|
@gkalpak. didn't see that 😅 Updated now |
gkalpak
suggested changes
Sep 10, 2018
docs/content/api/index.ngdoc
Outdated
| @@ -5,7 +5,7 @@ | |||
| # AngularJS API Docs | |||
|
|
|||
| <div class="alert alert-warning"> | |||
| **AngularJS will be moving to Long Term Support (LTS) mode on July 1st 2018.**: [Find out more](misc/version-support-status). | |||
| **On July 1, 2018 AngularJS entered a 3 year Long Term Support period..**: [Find out more](misc/version-support-status). | |||
There was a problem hiding this comment.
Double dots after period 😱 In fact non of the dots is needed, since they are followed by :. Can you, please, remove them both?
Also, for the sake of consistency (with the README 😳), lets put the closing ** after the : 😇
gkalpak
approved these changes
Sep 10, 2018
gkalpak
pushed a commit
that referenced
this pull request
Sep 10, 2018
|
I squashed the commits and merged. Thx 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements