This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(angular.element): do not break on cleanData() if _data() returns undefined
#16642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rns undefined This shouldn't happen in supported jQuery versions (2+), but if someone uses the unsupported 1.x version the app will break. The change that causes this new behavior was introduced in b7d396b. Even though jQuery 1.x is not supported, it is worth avoiding the unnecessary breakage (given how simple). Fixes angular#16641
gkalpak
changed the title
jQuery._data() returns undefinedcleanData() if _data() returns undefined
gkalpak
force-pushed
the
fix-cleanData-when-no-data
branch
from
3f212ff to
69bba7e
Compare
petebacondarwin
approved these changes
Jul 22, 2018
mgol
approved these changes
Jul 22, 2018
|
The e2e tests are the usual disconnects and the unit test failure is a flakey Safari bootstrap test |
gkalpak
added a commit
that referenced
this pull request
Jul 23, 2018
…rns undefined This shouldn't happen in supported jQuery versions (2+), but if someone uses the unsupported 1.x version the app will break. The change that causes this new behavior was introduced in b7d396b. Even though jQuery 1.x is not supported, it is worth avoiding the unnecessary breakage (given how simple). Fixes #16641 Closes #16642
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't happen in supported jQuery versions (2+), but if someone uses the unsupported 1.x version the app will break. The change that causes this new behavior was introduced in b7d396b.
Even though jQuery 1.x is not supported, it is worth avoiding the unnecessary breakage (given how simple).
Fixes #16641.