Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(changelog, guide/Migration): add info about $sce BC in 1.7 #16622

Merged
merged 3 commits into from
Jul 4, 2018

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Jul 3, 2018

Closes #16593

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion. LGTM otherwise.

CHANGELOG.md Outdated
@@ -463,6 +463,35 @@ Note that values that have been passed through the `$interpolate` service within
`URL` or `MEDIA_URL` will have already been sanitized, so you would not need to sanitize
these values again.

- due to **[1e9ead](https://github.com/angular/angular.js/commit/1e9eadcd72dbbd5c67dae8328a63e535cfa91ff9)**: handle URL sanitization through the `$sce` service

binding `trustAs()` and the short versions `trustAsResourceUrl()` et. al. to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would somehow separate the "trustAsResourceUrl() et. al." part from the rest of the sentence. E.g. wrap it in (...), , ... ,, - ... -.

@Narretz Narretz merged commit 74726b4 into angular:master Jul 4, 2018
@Narretz Narretz deleted the docs-sce-bc branch July 4, 2018 12:49
Narretz added a commit that referenced this pull request Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 $digest() iterations reached using $sce.trustAsResourceUrl with angularjs 1.7.0
3 participants