This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($location): move repeated path normalization code into helper method #16618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
approved these changes
Jul 18, 2018
src/ng/location.js
Outdated
| this.$$absUrl = appBaseNoFile + this.$$url.substr(1); // first char is always '/' | ||
|
|
||
| this.$$urlUpdatedByLocation = true; | ||
| this.$$normalizeUrl = function(path) { |
There was a problem hiding this comment.
I think $$normalizeUrl's argument should be named url (not path), because that is what it is (in $location terms).
There was a problem hiding this comment.
Hmm... even though it's actually (part of) a path? The main thing this method does is append a base path to the argument. Seems like this is more of a path2url method...
There was a problem hiding this comment.
It is not necessarilt part of the path. It also contains query and hash fragment. So, technically it is part the browser URL.
But in $location terms, it is the URL (which is why $$normalizeUrl() is called with $location.$$url 😁).
|
Updated |
jbedard
force-pushed
the
16100-refactor
branch
2 times, most recently
from
2329f97 to
db77c39
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor to reduce duplicate code
Other information:
I originally did this as part of an attempted solution in #16611, but I thought it might be worth committing on it's own.