This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($httpBackend): headers param of expect* can be function
#16588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
reviewed
Jun 4, 2018
src/ngMock/angular-mocks.js
Outdated
| @@ -1744,7 +1744,8 @@ function createHttpBackendMock($rootScope, $timeout, $delegate, $browser) { | |||
| * | |||
| * @param {string|RegExp|function(string)=} url HTTP url or function that receives a url | |||
| * and returns true if the url matches the current definition. | |||
| * @param {Object=} headers HTTP headers. | |||
| * @param {(Object|function(Object))=} headers HTTP headers or function that receives http header | |||
| * object and returns true if the headers match the current expectation. | |||
There was a problem hiding this comment.
expectation --> definition_ (?)
(To be consistent with the url param description above.)
There was a problem hiding this comment.
It's the other way round: expect* create "expectations", when* create "definitions". The description for url needs to be changed here.
thorn0
force-pushed
the
patch-16
branch
2 times, most recently
from
a0c21b2 to
ba498a3
Compare
gkalpak
approved these changes
Jun 4, 2018
gkalpak
pushed a commit
that referenced
this pull request
Jun 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.