Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(jqLite): use XHTML-compliant HTML as input for jqLite #16518

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 28, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix.

What is the current behavior? (You can also link to an open issue here)

#6917

What is the new behavior (if this is a feature change)?

Closing tags are added to HTML passed to jqLite which should make it XHTML-compliant.

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated (N/A)
  • Fix/Feature: Tests have been added; existing tests pass (we don't test on XHTML so it can't be tested)

Other information:

Fixes #6917

Copy link
Contributor

@Narretz Narretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note to the docs that input to jqlite must be XHTML compliant? This does affect user-code, too, right?

@mgol
Copy link
Member Author

mgol commented Mar 29, 2018

Should we add a note to the docs that input to jqlite must be XHTML compliant? This does affect user-code, too, right?

Yes, but only if they care about XHTML which the vast majority of users doesn't do (and doesn't need to).

What note would you have in mind?

@Narretz
Copy link
Contributor

Narretz commented Mar 30, 2018

Hm I guess if somebody cares about XHTML compliance then they should be aware of this. No need to add a note.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jqLite('<div>') throws an error in an XHTML document
5 participants