This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(ngMock): remove a broken jqLite cache clearing #16515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the resetting of `angular.element.cache` in some tests; this was desynchronizing jqLite.cache & the local jqCache variable and since some parts of the code use one of them and some the other one, it was breaking JQLite._data. `angular.element.cache` doesn't even exist when jQuery 2+ is used.
gkalpak
approved these changes
Mar 28, 2018
mgol
added a commit
that referenced
this pull request
Mar 28, 2018
This commit removes the resetting of `angular.element.cache` in some tests; this was desynchronizing jqLite.cache & the local jqCache variable and since some parts of the code use one of them and some the other one, it was breaking JQLite._data. `angular.element.cache` doesn't even exist when jQuery 2+ is used. Closes #16515 Refs #16512
mgol
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A test change.
What is the current behavior? (You can also link to an open issue here)
angular.element.cacheis reset to an empty object in one spec.What is the new behavior (if this is a feature change)?
It's no longer reset at all.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Fix/Feature: Docs have been added/updatedFix/Feature: Tests have been added; existing tests passOther information:
This is blocking PR #16512.