This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test($rootScope): add tests clarifying $watchGroup oldValues behavior #16494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
16024
branch
2 times, most recently
from
87c5785 to
96dcafe
Compare
gkalpak
approved these changes
Mar 19, 2018
There was a problem hiding this comment.
LGTM except that:
- You need to have a
:afterBREAKING CHANGEin the commit message (per guidelines) 😁 - The breaking change notice doesn't make it clear that it refers to
$watchGroup(). - Since this is a
test(...)commit, it won't be included in the changelog (so we still need to manually include the BC, I think).
jbedard
force-pushed
the
16024
branch
2 times, most recently
from
aebf6b0 to
a8ddb03
Compare
|
I've updated the commit message and removed the extra comments from the tests. |
|
Also created #16514 for updating the changelog like we discussed |
gkalpak
approved these changes
Mar 28, 2018
|
Is the BC message 100% clear? There must be at least one typo in there! 😆 |
It is to me.
Well...if you absolutely want to fix a typo, you can fix "will will lways" 😁 |
|
Will fix that. Now I know you read it! 😄 |
|
Fixed the typo in the commit message. |
Closes angular#16024 BREAKING CHANGE: (caused by c2b8fab) Previously when using `$watchGroup` the entries in `newValues` and `oldValues` represented the *most recent change of each entry*. Now the entries in `oldValues` will always equal the `newValues` of the previous call of the listener. This means comparing the entries in `newValues` and `oldValues` can be used to determine which individual expressions changed. For example `$scope.$watchGroup(['a', 'b'], fn)` would previously: | Action | newValue | oldValue | |----------|------------|------------| | (init) | [undefined, undefined] | [undefined, undefined] | | `a=1` | [1, undefined] | [undefined, undefined] | | `a=2` | [2, undefined] | [1, undefined] | | `b=3` | [2, 3] | [1, undefined] | Now the `oldValue` will always equal the previous `newValue`: | Action | newValue | oldValue | |----------|------------|------------| | (init) | [undefined, undefined] | [undefined, undefined] | | `a=1` | [1, undefined] | [undefined, undefined] | | `a=2` | [2, undefined] | [1, undefined] | | `b=3` | [2, 3] | [2, undefined] | Note the last call now shows `a === 2` in the `oldValues` array. This also makes the `oldValue` of one-time watchers more clear. Previously the `oldValue` of a one-time watcher would remain `undefined` forever. For example `$scope.$watchGroup(['a', '::b'], fn)` would previously: | Action | newValue | oldValue | |----------|------------|------------| | (init) | [undefined, undefined] | [undefined, undefined] | | `a=1` | [1, undefined] | [undefined, undefined] | | `b=2` | [1, 2] | [undefined, undefined] | | `a=b=3` | [3, 2] | [1, undefined] | Where now the `oldValue` will always equal the previous `newValue`: | Action | newValue | oldValue | |----------|------------|------------| | (init) | [undefined, undefined] | [undefined, undefined] | | `a=1` | [1, undefined] | [undefined, undefined] | | `b=2` | [1, 2] | [1, undefined] | | `a=b=3` | [3, 2] | [1, 2] |
|
I've merged the commit without the BC message. In a test scope commit it's just confusing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16024
The first group seem related but have always passed. The second group fail in v1.6.x as noted in the comments. IMO these tests (with the notes about 1.6) show how weird the
oldValueswere before.Still need to add the BREAKING CHANGE message.