This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngShow/ngHide): add note about flicker when toggling elements #16489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
approved these changes
Mar 13, 2018
src/ng/directive/ngShowHide.js
Outdated
| * | ||
| * ### Flickering when using ngShow to toggle between elements | ||
| * | ||
| * When using {@link ngShow} and / or {@link ngHide} to toggle between elements , it can |
src/ng/directive/ngShowHide.js
Outdated
| * ### Flickering when using ngShow to toggle between elements | ||
| * | ||
| * When using {@link ngShow} and / or {@link ngHide} to toggle between elements , it can | ||
| * happen that both the element to show and the element to hide are visible at the same time. |
There was a problem hiding this comment.
I would mention that this only happens for a brief moment; it is not a permanent state.
It might also be worth mentioning that it affects some browsers (*cough* IE *cough*) more than others.
src/ng/directive/ngShowHide.js
Outdated
| * There are several way to mitigate this problem: | ||
| * | ||
| * - {@link guide/animations#how-to-selectively-enable-disable-and-skip-animations Disable animations on the affected elements}. | ||
| * - Use {@link ngIf} instead of {@link ngShow} / {@link ngHide}. |
There was a problem hiding this comment.
Actually, if you are toggling, ngSwitch is more appropriate 😁
src/ng/directive/ngShowHide.js
Outdated
| * - {@link guide/animations#how-to-selectively-enable-disable-and-skip-animations Disable animations on the affected elements}. | ||
| * - Use {@link ngIf} instead of {@link ngShow} / {@link ngHide}. | ||
| * - Use the special CSS selector `ng-hide.ng-hide-animate` to set `{display: none}` or similar on the affected elements . | ||
| * - Define an animation on the affected elements. |
src/ng/directive/ngShowHide.js
Outdated
| * This usually happens when the {@link ngAnimate ngAnimate module} is included, but no actual animations | ||
| * are defined for {@link ngShow} / {@link ngHide}. | ||
| * | ||
| * There are several way to mitigate this problem: |
There was a problem hiding this comment.
How about using ng-class="{'ng-hide': expression}?
src/ng/directive/ngShowHide.js
Outdated
| * | ||
| * - {@link guide/animations#how-to-selectively-enable-disable-and-skip-animations Disable animations on the affected elements}. | ||
| * - Use {@link ngIf} instead of {@link ngShow} / {@link ngHide}. | ||
| * - Use the special CSS selector `ng-hide.ng-hide-animate` to set `{display: none}` or similar on the affected elements . |
There was a problem hiding this comment.
Extra whitespace before the period.
Narretz
force-pushed
the
docs-ngshow-flicker
branch
2 times, most recently
from
707d21f to
4ad23ca
Compare
gkalpak
pushed a commit
that referenced
this pull request
Mar 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14015
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: