This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(docs.angular.js): do not break when deploying #16452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Narretz
approved these changes
Feb 12, 2018
gkalpak
force-pushed
the
ci-fix-deploy-docs
branch
from
2ee7ce5 to
373e102
Compare
gkalpak
force-pushed
the
ci-fix-deploy-docs
branch
from
373e102 to
1973fc9
Compare
|
I added scripts/code.angularjs.org-firebase/.eslintrc.json, because apparently it is needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #16451.
The firebase predeploy step (
npm run lint) was failing because the dependencies had not been installed at that time. The predeploy step is not necessary, because we should be lnting the files as part of ourci-checksjob.