Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix deprecate ngtouch #16431

Merged
merged 1 commit into from
Feb 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/ngTouch/directive/ngSwipe.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
* @ngdoc directive
* @name ngSwipeLeft
*
* @deprecated
* sinceVersion="1.7.0"
*
* See the {@link ngTouch module} documentation for more information.
*
* @description
* Specify custom behavior when an element is swiped to the left on a touchscreen device.
* A leftward swipe is a quick, right-to-left slide of the finger.
Expand Down Expand Up @@ -42,6 +47,11 @@
* @ngdoc directive
* @name ngSwipeRight
*
* @deprecated
* sinceVersion="1.7.0"
*
* See the {@link ngTouch module} documentation for more information.
*
* @description
* Specify custom behavior when an element is swiped to the right on a touchscreen device.
* A rightward swipe is a quick, left-to-right slide of the finger.
Expand Down
5 changes: 5 additions & 0 deletions src/ngTouch/swipe.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
* @ngdoc service
* @name $swipe
*
* @deprecated
* sinceVersion="1.7.0"
*
* See the {@link ngTouch module} documentation for more information.
*
* @description
* The `$swipe` service is a service that abstracts the messier details of hold-and-drag swipe
* behavior, to make implementing swipe-related directives more convenient.
Expand Down
7 changes: 7 additions & 0 deletions src/ngTouch/touch.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
*
* See {@link ngTouch.$swipe `$swipe`} for usage.
*
* @deprecated
* sinceVersion="1.7.0"
* The ngTouch module with the {@link ngTouch.$swipe `$swipe`} service and
* the {@link ngTouch.ngSwipeLeft} and {@link ngTouch.ngSwipeRight} directives are
* deprecated. Instead, stand-alone libraries for touch handling and gesture interaction
* should be used, for example [HammerJS](https://hammerjs.github.io/) (which is also used by
* Angular).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be confusing to people not aware of the AngularJS-vs-Angular distinction.
Maybe add a link to Angular or make it more explicit that you refer to the newer version (or both 😁).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the naming change was a pretty big deal so I think it's okay.

*/

// define ngTouch module
Expand Down