Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(PULL_REQUEST_TEMPLATE.md): fix broken links in PR template #16377

Merged
merged 1 commit into from
Dec 19, 2017
Merged

docs(PULL_REQUEST_TEMPLATE.md): fix broken links in PR template #16377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- General PR submission guidelines https://github.com/angular/angular.js/CONTRIBUTING.md#submit-pr -->
<!-- General PR submission guidelines https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#submit-pr -->
**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**


Expand All @@ -16,8 +16,8 @@


**Please check if the PR fulfills these requirements**
- [ ] The commit message follows our [guidelines](../DEVELOPERS.md#commits)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this and the other link below to be relative? ../blob/master/DEVELOPERS.md#commits This way, they work the same in forks.

Copy link
Contributor Author

@frederikprijck frederikprijck Dec 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm this doesn't seem to work in every situation, using an absolute url does.

I did the following:

  • Edit the template file using github UI
  • Update the URL to reflect ur changes
  • Preview the file
  • Click the link to test if it works and see it won't work coz it tries to navigate to https://github.com/frederikprijck/angular.js/blob/patch-2/blob/master/DEVELOPERS.md#commits

@Narretz Am I missing something? And what's the benefit of using a relative link to a hardcoded branch over an absolute one to the same branch?

Tbh I'd would love to have a solution which points to the file in the correct branch. However, I'm not sure that's worth the effort as there's other hardcoded absolute urls in the repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay the relative format only works well if you are in the repository view / file tree. It doesn't work as part of the PR template. Just leave it absolute.

Copy link
Contributor Author

@frederikprijck frederikprijck Dec 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use /Developers.md!

Edit: Nvm, doesn't seem to behave the same in all situations.

- [ ] Fix/Feature: [Docs](../DEVELOPERS.md#documentation) have been added/updated
- [ ] The commit message follows our [guidelines](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits)
- [ ] Fix/Feature: [Docs](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#documentation) have been added/updated
- [ ] Fix/Feature: Tests have been added; existing tests pass

**Other information**:
Expand Down