This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAria): do not set aria attributes on input[type="hidden"] #16367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a error found by @edclements using the Google Accessibility Developer Tools audit.
Input fields of type hidden shouldn't have aria attributes.
https://www.w3.org/TR/html-aria/#allowed-aria-roles-states-and-properties-1
Closes #15113
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
aria attributes added to input type hidden
What is the new behavior (if this is a feature change)?
Not anymore.
Does this PR introduce a breaking change?
I would say not actually, because the previous behavior didnt follow the spec and I can'T see why anyone would rely on this behavior. It was marked as breaking change in #15113, though
Please check if the PR fulfills these requirements
Other information:
Rebased and updated version of #15113