This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(*): bump Yarn in Jenkins init-node script #16365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it Jenkins builds are broken.
mgol
changed the title
petebacondarwin
approved these changes
Dec 7, 2017
mgol
added a commit
that referenced
this pull request
Dec 7, 2017
Without it Jenkins builds are broken. Closes #16365
gkalpak
reviewed
Dec 8, 2017
| @@ -8,7 +8,7 @@ nvm install | |||
|
|
|||
| # clean out and install yarn | |||
| rm -rf ~/.yarn | |||
| curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 0.21.3 | |||
| curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.3.2 | |||
There was a problem hiding this comment.
We should have such values in one place, so we don't have to update them in several files each time. E.g. have a scripts/env.sh and import it in all places where we need them.
There was a problem hiding this comment.
We can't cover all of them as we can't import anything in package.json. But Jenkins/Travis versions could be shared, yes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it Jenkins builds are broken.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: