Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ng-model-options): remove extra quotes in example, incorrect syntax #16362

Closed
wants to merge 1 commit into from

Conversation

jjhampton
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update - fix incorrect syntax used in example of ng-model-options attribute directive in documentation at https://docs.angularjs.org/api/ng/directive/ngModelOptions

What is the current behavior? (You can also link to an open issue here)
Current docs show quotes are around the attribute name within the element tag:
<div "ng-model-options"="{ debounce: 100 }"

What is the new behavior (if this is a feature change)?
No quotes around the attribute name within the element tag:
<div ng-model-options="{ debounce: 100 }"

Does this PR introduce a breaking change?
No

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@jjhampton
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 6, 2017
@jjhampton jjhampton changed the title Fix incorrect syntax on ng-model-options example in docs docs(ng-model-options): Remove extra quotes in example, incorrect syntax Dec 6, 2017
@gkalpak
Copy link
Member

gkalpak commented Dec 7, 2017

Good catch! Thx 👍
Can you please update the commit message to follow our guidelines?

@gkalpak gkalpak added this to the Purgatory milestone Dec 7, 2017
@jjhampton jjhampton changed the title docs(ng-model-options): Remove extra quotes in example, incorrect syntax docs(ng-model-options): remove extra quotes in example, incorrect syntax Dec 8, 2017
Remove unnecessary quotes around attribute directive name in the docs example.  This syntax is incorrect.
@jjhampton
Copy link
Contributor Author

@gkalpak Thank you for reviewing - I've updated the commit message to follow the guidelines and re-pushed those changes.

@gkalpak gkalpak closed this in 00815db Dec 11, 2017
gkalpak pushed a commit that referenced this pull request Dec 11, 2017
Remove unnecessary quotes around attribute directive name in the docs example.  This syntax is incorrect.

Closes #16362
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants