-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(ng-model-options): remove extra quotes in example, incorrect syntax #16362
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@googlebot I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Good catch! Thx 👍 |
Remove unnecessary quotes around attribute directive name in the docs example. This syntax is incorrect.
@gkalpak Thank you for reviewing - I've updated the commit message to follow the guidelines and re-pushed those changes. |
Remove unnecessary quotes around attribute directive name in the docs example. This syntax is incorrect. Closes #16362
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update - fix incorrect syntax used in example of ng-model-options attribute directive in documentation at https://docs.angularjs.org/api/ng/directive/ngModelOptions
What is the current behavior? (You can also link to an open issue here)
Current docs show quotes are around the attribute name within the element tag:
<div "ng-model-options"="{ debounce: 100 }"
What is the new behavior (if this is a feature change)?
No quotes around the attribute name within the element tag:
<div ng-model-options="{ debounce: 100 }"
Does this PR introduce a breaking change?
No