Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

build(*): update Node from 6 to 8, update Yarn #16360

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Dec 6, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Build-related.

What is the current behavior? (You can also link to an open issue here)

We use Node 6 & an old Yarn version.

What is the new behavior (if this is a feature change)?

We use Node 8 & a new Yarn version.

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

Other information:

Angular (2+) switched to Node 8 and so should we.

Ref angular/angular#20807
Ref angular/angular#20832

@gkalpak
Copy link
Member

gkalpak commented Dec 6, 2017

Travis is red. Other than that seems reasonable 😃
Didn't that yarn.lock file need updating?

Angular (2+) switched to Node 8 and so should we.

Ref angular/angular#20807
Ref angular/angular#20832
@mgol mgol changed the title build(*): Update Node from 6 to 8, update Yarn build(*): update Node from 6 to 8, update Yarn Dec 6, 2017
@mgol
Copy link
Member Author

mgol commented Dec 6, 2017

Didn't that yarn.lock file need updating?

i run yarn and it didn't modify the lockfile so I think we're fine.

@mgol mgol merged commit a768810 into angular:master Dec 7, 2017
@mgol mgol deleted the node-8 branch December 7, 2017 18:26
mgol added a commit that referenced this pull request Dec 7, 2017
Angular (2+) switched to Node 8 and so should we.

Closes #16360
Ref angular/angular#20807
Ref angular/angular#20832
@IgorMinar
Copy link
Contributor

thanks @mgol!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants