This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(linky): mark "target" param as optional in linky filter #16330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This argument is optional in practice, and it is not provided in many of the examples in the documentation. Its optional presence is handled here: https://github.com/angular/angular.js/blob/master/src/ngSanitize/filter/linky.js#L185.
kirkthompson
force-pushed
the
linky-doc
branch
from
4929ba0 to
884f5ec
Compare
petebacondarwin
approved these changes
Nov 15, 2017
Narretz
pushed a commit
that referenced
this pull request
Nov 17, 2017
This argument is optional in practice, and it is not provided in many of the examples in the documentation. Its optional presence is handled here: https://github.com/angular/angular.js/blob/f876ab71913e17e9126baad19ab795f28b61bfe6/src/ngSanitize/filter/linky.js#L185 Closes #16330
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument is optional in practice, and it is not provided in many of the examples in the documentation.
Its optional presence is handled here:
https://github.com/angular/angular.js/blob/master/src/ngSanitize/filter/linky.js#L185.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
The second argument to ngSanitize's "linky" filter is marked as non-optional, it is handled as optional and usage shows it as being optional.
What is the new behavior (if this is a feature change)?
ngSanitize's "linky" filter has it's second parameter marked as optional.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information: