This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(tutorial/14 - Animations): replace broken web platform docs link #16294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace broken link [webplatform-animations]: https://docs.webplatform.org/wiki/css/properties/animations with [mdn-animations]: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Animations/Using_CSS_animations https://docs.webplatform.org/wiki/css/properties/animations returns a 404. The closest match that works is https://webplatform.github.io/docs/css/properties/animation. However, the notice at the top of the page reads, "The WebPlatform project, supported by various stewards between 2012 and 2015, has been discontinued." The CSS animations guide on MDN web docs is not only current, but also more comprehensive.
gkalpak
approved these changes
Oct 23, 2017
gkalpak
pushed a commit
that referenced
this pull request
Oct 23, 2017
Replace broken [webplatform-animations][1] link with [mdn-animations][2]. The original link returns a 404. The closest match that works is https://webplatform.github.io/docs/css/properties/animation. However, the notice at the top of the page reads: > The WebPlatform project, supported by various stewards between 2012 > and 2015, has been discontinued. The CSS animations guide on MDN web docs is not only current, but also more comprehensive. [1]: https://docs.webplatform.org/wiki/css/properties/animations [2]: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Animations/Using_CSS_animations Closes #16294
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update
What is the current behavior? (You can also link to an open issue here)
The Web Platform documentation link is broken (https://github.com/angular/angular.js/blob/master/docs/content/tutorial/step_14.ngdoc#L331).
It returns a 404.
What is the new behavior (if this is a feature change)?
Replace broken link [webplatform-animations]:
https://docs.webplatform.org/wiki/css/properties/animations
with [mdn-animations]:
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Animations/Using_CSS_animations
Since the WebPlatform project has been discontinued, replace it with the MDN web docs.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
The closest match that works is https://webplatform.github.io/docs/css/properties/animation. However, the notice at the top of the page reads, "The WebPlatform project, supported by various stewards between 2012 and 2015, has been discontinued."
The CSS animations guide on MDN web docs is not only current, but also more comprehensive.