This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore($resource): remove obsolete API #16267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has been in the $resource service since 2010, but was never documented and can therefore be removed. It'll save precious bytes! Shout-out to @gkalpak for finding this
Narretz
changed the title
|
What happens to the developer out there that really is using this undocumented API? |
|
I doubt anyone is using this, but ofc we cannot be sure. |
|
I was just looking through the source code (working on another issue) and stumbled upon that. I fixed it kust in case; I don't know anyone using it 😃 |
|
OK, so let's remove it and see if anyone complains. We can always add it back in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been in the $resource service since 2010, but was
never documented and can therefore be removed. It'll save precious bytes!
Shout-out to @gkalpak for finding this.
Technically, we don't have to remove it, but it doesn't make sense to keep it in the repository either. It leads to devs fixing bugs in undocumented APIs: 6eb4ffc ;)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
obsolete code removal
Does this PR introduce a breaking change?
No 😛
Please check if the PR fulfills these requirements
Other information: