-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore(*): add a Git .mailmap with my new name #16254
Conversation
Interesting. Maybe that's why for a while my commits are saying Martin Staffa committed with Martin Staffa. |
@Narretz I added entries for all the people from top 25 or so that had multiple distinct entries in Git commit history. On your name: Before:
After:
|
…ntries In this way: * my past contributions are mapped correctly * other people's distinct entries are collapsed into one
Cool, thanks. How did you determine which is the canonical email for Igor etc. where it is not exactly clear? |
@Narretz Good question! I checked what mail he used in his latest commit to https://github.com/angular/angular; similarly for other people (for some I checked https://github.com/angular/angular.js instead). |
BTW, apart from
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that sounds good. Feel free to merge
In this way: * my past contributions are mapped correctly * other people's distinct entries are collapsed into one Closes #16254
In this way: * my past contributions are mapped correctly * other people's distinct entries are collapsed into one Closes #16254
In this way my past contributions are mapped correctly.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore.
What is the current behavior? (You can also link to an open issue here)
Git thinks I'm 2 people.
What is the new behavior (if this is a feature change)?
I'm one person again.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information:
Output of
git shortlog -nse | head -25
after this PR (I see we could use more.mailmap
entries, there are lots of duplicates):