This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(*): don't hide results for middle-clicks #16233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
petebacondarwin
approved these changes
Sep 21, 2017
Middle-clicking opens a link in a new tab; it shouldn't close the results list as the user may want to open more of those links. Closes angular#16233
mgol
force-pushed
the
middle-click-no-hide
branch
from
0d7f74d to
da6ae8b
Compare
mgol
added a commit
that referenced
this pull request
Sep 21, 2017
Middle-clicking opens a link in a new tab; it shouldn't close the results list as the user may want to open more of those links. Closes #16233
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middle-clicking opens a link in a new tab; it shouldn't close the results list
as the user may want to open more of those links.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs fix.
What is the current behavior? (You can also link to an open issue here)
Middle-clicking on a link in the results list (which opens a link in a new tab) closes the list.
What is the new behavior (if this is a feature change)?
List is kept open in such a case.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information: