This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs: add calrification for RegExp in ngPattern #16206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YonatanKra
force-pushed
the
patch-4
branch
2 times, most recently
from
360d404 to
f288e73
Compare
|
Is this failing because angularjs.org is down? |
`ngPattern` accepts only valid regExp pattern, hence it should be excepted from the `No RegExp Creation With Literal Notation` rule.
gkalpak
approved these changes
Sep 5, 2017
gkalpak
pushed a commit
that referenced
this pull request
Sep 5, 2017
…ttern` expression The `ngPattern` expression does accept a RegExp created with literal notation, hence it should be mentioned as an exception to the "No RegExp Creation With Literal Notation" rule. Closes #16206
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngPatternaccepts only valid regExp pattern, hence it should be excepted from theNo RegExp Creation With Literal Notationrule.What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs
What is the current behavior? (You can also link to an open issue here)
States that RegExp are not valid in expressions.
What is the new behavior (if this is a feature change)?
State that RegExp is valid in ngPattern.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: