Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(code.angular): correctly remove old zip files from snapshot #16168

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Aug 11, 2017

Previously, the event would be triggered on the deletion of the previous zip files,
which would delete the current zip file as well

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

Previously, the event would be triggered on the deletion of the previous zip files,
which would delete the current zip file as well
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a good way to test this, but it looks good 😃

@Narretz
Copy link
Contributor Author

Narretz commented Aug 11, 2017

You said that the last time I changed this 😄
But this time I tested it more thoroughly

@Narretz Narretz merged commit 919087f into angular:master Aug 11, 2017
@Narretz Narretz deleted the chore-firebase-zip-delete branch August 11, 2017 20:54
@gkalpak
Copy link
Member

gkalpak commented Aug 11, 2017

At least I am consistent 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants