This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($compile): update preAssignBindingsEnabled description #16162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The migration guide doesn't mention that pre-assignment is about the bindings being available inside the component/directive's controller constructor, the changelog does. Would it make sense to explicitly mention it in the migration guide aswell? |
gkalpak
approved these changes
Aug 10, 2017
|
I am fine with the current content, but if you want to add that to the migration guide, I will wait 😛 |
Previously, the changelog and migration guide did not mention the fact that this only applies to controllers which are part of a directive/component. This commit ensures the changelog and migration guide mentions this explicitly. Closes #15740
|
Updated 🙈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update
What is the current behavior? (You can also link to an open issue here)
The changelog and migration guide does not mention the fact that this only applies to controllers which are part of a directive/component.
What is the new behavior (if this is a feature change)?
The changelog and migration guide does mention it.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
#15740