This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/Running in Production): more Information on debugInfoEnabled(false) #16155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
suggested changes
Aug 8, 2017
docs/content/guide/production.ngdoc
Outdated
| @@ -16,10 +16,16 @@ and adds CSS classes to data-bound elements: | |||
| - As a result of `ngBind`, `ngBindHtml` or `{{...}}` interpolations, binding data and CSS class | |||
| `ng-binding` are attached to the corresponding element. | |||
|
|
|||
| - Whenever a value is bound to an element, that element gains a data property, `$binding`, containing an | |||
There was a problem hiding this comment.
This is what the previous point refers to. I would argue that the exact name and value of the property don't need to be mentioned here.
docs/content/guide/production.ngdoc
Outdated
| - Where the compiler has created a new scope, the scope and either `ng-scope` or `ng-isolated-scope` | ||
| CSS class are attached to the corresponding element. These scope references can then be accessed via | ||
| `element.scope()` and `element.isolateScope()`. | ||
|
|
||
| - Placeholder comments for directives which affect the DOM will contain information about what directive |
There was a problem hiding this comment.
Let's change "for directives which affect the DOM" to "for structural directives".
…ed(false) Added bullet mentioning that the placeholder comments are also affected.
oBusk
changed the title
|
@gkalpak I've ammended according to your comments. Thanks for the feedback. |
gkalpak
pushed a commit
that referenced
this pull request
Aug 23, 2017
Add bullet mentioning how placeholder comments are affected. Closes #16155
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Improves documentation about what
$compileProvider.debugInfoEnabled(true)does.Other information:
Based on compile.js source code.
Please feel free to improve the wording or come with feedback.
Related: #16154